Skip to content

Fix incorrect link in Makefile.in documentation #20282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2014

Conversation

WebDrake
Copy link
Contributor

This is a very trivial fix for a broken link that I noticed while building the compiler for the first time. I've changed it to its presumed successor.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@nikomatsakis
Copy link
Contributor

I honestly have no idea what the content of that page was, but a broken link certainly does not seem particularly useful.

@WebDrake
Copy link
Contributor Author

Looking through the wiki git history, Note-build-system.md was removed on 2014-06-19 in wiki commit d91b9956d8dde1a883c2dcc5dba168efb82ae3ef -- it was a big cleanup of allegedly obsolete pages. The page itself contained pretty much what is now documented in Makefile.in itself, i.e. a list of build targets.

There's a link on the "getting started" page to "build system notes", which used to point to the now-removed wiki page, and since 2014-06-28 (wiki commit b9139fba12767cdcacd147a11f4265e22f59ece2) that link points to Makefile.in line 11.

Of all wiki pages, the getting-started guide seems the most useful to link to from the Makefile, but I'll happily tweak if there are any better ideas :-)

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 30, 2014
This is a very trivial fix for a broken link that I noticed while building the compiler for the first time.  I've changed it to its presumed successor.
@bors bors merged commit 8c881cd into rust-lang:master Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants